[Openmp-commits] [PATCH] D110109: [OpenMP] libomp: add atomic functions for new OpenMP 5.1 atomics.
Andrey Churbanov via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Thu Oct 21 12:25:50 PDT 2021
AndreyChurbanov added a comment.
In D110109#3077855 <https://reviews.llvm.org/D110109#3077855>, @kkwli0 wrote:
> Is this patch only applicable to `KMP_ARCH_X86 || KMP_ARCH_X86_64` arch? The newly added test cases fail on non-X86 platform due to undefined symbols. The `__kmpc_atomic_*_cas_*` prototypes got preprocessed out inside the `extern "C"` hence the names are mangled.
Thanks for comment. The implementation is indeed supposed to be applicable to `KMP_ARCH_X86 || KMP_ARCH_X86_64` only.
I've fixed the tests in commit https://reviews.llvm.org/rG52f4922ebb7b. Library code fixed in https://reviews.llvm.org/D112261 to eliminate mangled symbols from the build on non-x86 architectures.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits