[Openmp-commits] [PATCH] D112205: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton added inline comments.


================
Comment at: openmp/runtime/test/ompt/worksharing/taskinfo/sections_serialized.c:9
+__attribute__ ((noinline)) // workaround for bug in icc
+void print_task_info_at(int ancestor_level)
+{
----------------
Can we not use `print_ids()` from callback.h?


================
Comment at: openmp/runtime/test/ompt/worksharing/taskinfo/sections_serialized.c:31
+
+void spin_wait() {
+  while (wait == 0);
----------------
Use `#include "ompt-signal.h" and the wait and signal functions inside that header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112205/new/

https://reviews.llvm.org/D112205