[Openmp-commits] [PATCH] D112156: [OpenMP] Ensure broken assumptions print once, not thousands of times.
Jon Chesterfield via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Thu Oct 21 01:02:29 PDT 2021
JonChesterfield added inline comments.
Comment at: openmp/libomptarget/DeviceRTL/include/Utils.h:99
> Or we could use zero for the initial value and write 1 into it. Seq_cst seems unnecessary - acq_rel? Global ordering on GPUs is expensive and not obviously required here, don't care which thread wins the race to print a debug message
Actually worse than that - seq cst induces a global order. To make that work, we probably change thread execution ordering. Want to minimise assert's influence on dynamic control flow
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits