[Openmp-commits] [PATCH] D112083: [OpenMP] Remove macro guards for device debugging

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D112083#3073140 <https://reviews.llvm.org/D112083#3073140>, @JonChesterfield wrote:

> Seems inconsistent. Could we leave the debug output available in release builds across the host plugins? Measured in the noise for performance on rocm (branches are easily predicted) and it's useful to toggle debug output on without recompiling.

This is specifically for toggling debugging using the new device runtime, which will be the default very soon. The new device runtime has no concept of a debug version, and is instead configured at compile-time by the user by specifying `-fopenmp-target-debug=<N>`. At runtime the user then specifies `LIBOMPTARGET_DEVICE_RTL_DEBUG=<N>` to activate those features. Having the actual use of this being guarded by a separate debug build defeats the purpose at least on the device side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112083/new/

https://reviews.llvm.org/D112083