[Openmp-commits] [PATCH] D111983: [libomptarget][DeviceRTL] Generalise and simplify cmakelists

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D111983#3071816 <https://reviews.llvm.org/D111983#3071816>, @Meinersbur wrote:

> as by CMake's documentation:
>
>> APPEND
>> Append the COMMAND and DEPENDS option values to the custom command for the first output specified. There must have already been a previous call to this command with the same output.

Thanks! I misread that part of your first comment. Restored the corresponding parts to the order they were in previously. Curious that append before define was not reported as an error by cmake.



================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:178
 
+  # Add a file-level dependency to ensure that llvm-link and opt are up-to-date.
+  # By default, add_custom_command only builds the tool if the executable is missing
----------------
JonChesterfield wrote:
> I think it reads better to sort out the dependency for both tools before using them
^turns out dependencies come after use, not before, in this context


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111983/new/

https://reviews.llvm.org/D111983