[Openmp-commits] [PATCH] D112010: [OpenMP][Docs] Add documentation for device RTL debugging

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Unrelated: We should provide two sets of functions so that users can benefit from the same compile-time + runtime selection logic.

1. enter/exit functions, like above. In C++ we can even have a RAII
2. a generic "llvm_omp_is_debug_enabled(bit)" function that evaluates at compile time if the command line flag was not set.



================
Comment at: openmp/docs/design/Runtimes.rst:432
+is a 32-bit field used to selectively enable and disable different features.  
+Currently, the following debugging features are supported.
+
----------------
Make it explicit that both options (compile time and env var) need to be set. So only the bits set in both will actually be enabled.


================
Comment at: openmp/docs/design/Runtimes.rst:435
+    * Enable debugging assertions in the device. ``0x01``
+    * Enable OpenMP runtime function traces in the device. ``0x2``
+
----------------
We still need to find a way such that the number goes first, I always miss it online.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112010/new/

https://reviews.llvm.org/D112010