[Openmp-commits] [PATCH] D111905: [OpenMP][deviceRTLs] Fix wrong return value of `__kmpc_is_spmd_exec_mode`

Fri Oct 15 15:16:23 PDT 2021

dpalermo accepted this revision.
dpalermo added a comment.

I applied this change to see if it fixed the following (since this routine is called when deciding to serialize nested parallel regions):

https://bugs.llvm.org/show_bug.cgi?id=52169
Bug 52169 - [OpenMP] Wrong answers with nested 'omp parallel for'

...but I am still seeing the same behavior/wrong answers.

This patch looks good to me.  There is just something else remaining that is still causing a problem with nested parallel.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111905/new/

https://reviews.llvm.org/D111905