[Openmp-commits] [PATCH] D109921: [OpenMP][host runtime] Add support for teams affinity

[Terry Wilmarth via Phabricator via Openmp-commits]

tlwilmar requested changes to this revision.
tlwilmar added a comment.
This revision now requires changes to proceed.

Check potential KMP_AFFINITY_SUPPORTED changes mentioned in comments.



================
Comment at: openmp/runtime/src/kmp_runtime.cpp:5075
   int level = 0;
+  int do_place_partition = 1;
 
----------------
Can all of the code using do_place_partition go inside KMP_AFFINITY_SUPPORTED?


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:5263
 
-      KMP_CHECK_UPDATE(team->t.t_proc_bind, new_proc_bind);
+      if (do_place_partition) {
+        KMP_CHECK_UPDATE(team->t.t_proc_bind, new_proc_bind);
----------------
For example, here. Can KMP_AFFINITY_SUPPORTED wrap the whole if statement?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109921/new/

https://reviews.llvm.org/D109921