[Openmp-commits] [PATCH] D110957: [Libomptarget] Add an external interface to dynamic shared memory

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

ping.

In D110957#3051055 <https://reviews.llvm.org/D110957#3051055>, @JonChesterfield wrote:

> The plumbing here is all uncontroversial, it's just a wrapper over the openmp pragma.
>
> This won't work on amdgpu as-is, will need to pass the environment variable through to the HSA packet, and see what code clang emits for the allocator construct, and if that doesn't match what hip are using add lowering in the back end. There's nothing there that can't be done, just need to find the time.

NVPTX just sees anything with the `extern shared x[]` pattern in the PTX and hooks up the pointer to dynamic shared memory. I'm not sure if AMD uses a similar method, but if they do I think all that would need to be done is to add the argument to the config struct used in the AMD plugin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110957/new/

https://reviews.llvm.org/D110957