[Openmp-commits] [openmp] 0873b9b - [openmp] [elf_common] Fix linking against LLVM dylib

Michał Górny via Openmp-commits openmp-commits at lists.llvm.org
Mon Oct 4 00:29:47 PDT 2021


Author: Michał Górny
Date: 2021-10-04T09:29:06+02:00
New Revision: 0873b9bef4e03b4cfc44a4946c11103c763055df

URL: https://github.com/llvm/llvm-project/commit/0873b9bef4e03b4cfc44a4946c11103c763055df
DIFF: https://github.com/llvm/llvm-project/commit/0873b9bef4e03b4cfc44a4946c11103c763055df.diff

LOG: [openmp] [elf_common] Fix linking against LLVM dylib

The hand-rolled linking logic in elf_common does not account for
the possibility of using LLVM dylib rather than a dozen static
libraries.  Since it does not seem to be easily convertible
to add_llvm_library, just hand-roll support for LLVM_LINK_LLVM_DYLIB.
This is necessary to support stand-alone builds against installed LLVM.

Differential Revision: https://reviews.llvm.org/D111038

Added: 
    

Modified: 
    openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt b/openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt
index aad2e14318e05..457aab968556e 100644
--- a/openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt
+++ b/openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt
@@ -16,6 +16,9 @@ add_library(elf_common OBJECT elf_common.cpp)
 set_property(TARGET elf_common PROPERTY POSITION_INDEPENDENT_CODE ON)
 llvm_update_compile_flags(elf_common)
 set(LINK_LLVM_LIBS LLVMBinaryFormat LLVMObject LLVMSupport)
+if (LLVM_LINK_LLVM_DYLIB)
+  set(LINK_LLVM_LIBS LLVM)
+endif()
 target_link_libraries(elf_common INTERFACE ${LINK_LLVM_LIBS})
 include_directories(${LIBOMPTARGET_LLVM_INCLUDE_DIRS})
 add_dependencies(elf_common ${LINK_LLVM_LIBS})


        


More information about the Openmp-commits mailing list