[Openmp-commits] [PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

[Chi Chun Chen via Phabricator via Openmp-commits]

cchen added inline comments.


================
Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54
+         sa[1].f.b == &x[0] ? 1 : 0);
+  // CHECK: 111 222 777 20.00000 1
+
----------------
Do we really expect `sa[1].f.b` be the same as `&x[0]`? Shouldn't `sa[1].f.b` be the same as `&y[0]`?


================
Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:68
+  printf("%d %d %d %4.5f %d\n", sa[1].e, sa[1].f.a, sa[1].f.c.a, sa[1].f.b[1],
+         sa[1].f.b == &x[0] ? 1 : 0);
+  // CHECK: 333 222 777 40.00000 1
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100673/new/

https://reviews.llvm.org/D100673