[Openmp-commits] [PATCH] D102692: [AMDGPU][Libomptarget] Move Kernel/Symbol info tables to RTLDeviceInfoTy

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

passing by const& is much better than passing by &, I think we should do that in this patch



================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/atmi_interop_hsa.h:80
  */
 atmi_status_t atmi_interop_hsa_get_kernel_info(
+    std::map<std::string, atl_kernel_info_t> &KernelInfoTable,
----------------
This is only called from one place, with info == HSA_EXECUTABLE_SYMBOL_INFO_KERNEL_KERNARG_SEGMENT_SIZE, so can be simplified to a map lookup. Orthogonal to this patch.

This and get_symbol_info only do lookups in the map so we should pass the map to them by const&.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102692/new/

https://reviews.llvm.org/D102692