[Openmp-commits] [PATCH] D103115: [libomptarget][nfc][amdgpu] Remove atmi_status_t type

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue May 25 14:05:38 PDT 2021


JonChesterfield added a comment.
Herald added a subscriber: sstefan1.

Deleted the references to ATMI_STATUS_UNKNOWN manually, then

  for f in `find . -type f`; do sed -i 's$ATMI_STATUS_SUCCESS$HSA_STATUS_SUCCESS$g' $f; sed -i 's$ATMI_STATUS_ERROR$HSA_STATUS_ERROR$g' $f; sed -i 's$atmi_status_t$hsa_status_t$g' $f; done

and clang-format



================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/data.cpp:60
 
-  return (err == HSA_STATUS_SUCCESS) ? ATMI_STATUS_SUCCESS : ATMI_STATUS_ERROR;
+  return (err == HSA_STATUS_SUCCESS) ? HSA_STATUS_SUCCESS : HSA_STATUS_ERROR;
 }
----------------
This can be `return err;`, leaving that for a later patch to help with rebasing. Several patches to these files currently live.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103115/new/

https://reviews.llvm.org/D103115



More information about the Openmp-commits mailing list