[Openmp-commits] [PATCH] D102692: [AMDGPU][Libomptarget] Move Kernel/Symbol info tables to RTLDeviceInfoTy

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

except for the lost error check above, I think this is now a non-functional change. LG with that error path restored



================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:1123
                 info.size);
-    err = register_allocation(reinterpret_cast<void *>(info.addr),
-                              (size_t)info.size, place);
-    if (err != HSA_STATUS_SUCCESS) {
-      return err;
-    }
-    SymbolInfoTable[gpu][std::string(name)] = info;
+    register_allocation(reinterpret_cast<void *>(info.addr), (size_t)info.size,
+                        place);
----------------
lost an err = assignment and check here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102692/new/

https://reviews.llvm.org/D102692