[Openmp-commits] [PATCH] D103030: [libomptarget][nfc] Accept callable for hsa iterate_symbols

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D103030#2778888 <https://reviews.llvm.org/D103030#2778888>, @pdhaliwal wrote:

> Looks good. My opinion is that we should keep these wrappers in a separate file, but that could be a later patch.

Agreed, got stuck on picking a name and decided it was more important to get the diff up quickly.

There are a few things being considered for hsa:

- easier API via C++ wrapper
- wrapping calls in optional profiling collection
- dlopen hsa instead of link, for building llvm on systems without hsa installed

They're all somewhat related. I haven't put enough thought into the design space yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103030/new/

https://reviews.llvm.org/D103030