[Openmp-commits] [PATCH] D103030: [libomptarget][nfc] Accept callable for hsa iterate_symbols

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:1013
 
 static hsa_status_t populate_InfoTables(hsa_executable_t executable,
                                         hsa_executable_symbol_t symbol,
----------------
This change means populate_InfoTables can have a different type from the HSA callback, e.g. could take pointers to infotables directly


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:1243
     }
 
+    err = hsa::executable_iterate_symbols(
----------------
...because there can now be a capturing lambda to do the impedance mismatch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103030/new/

https://reviews.llvm.org/D103030