[Openmp-commits] [PATCH] D102499: [libomptarget][amdgpu] Mark alloc, free weak to facilitate local experimentation

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

I'm expecting to have a few in flight locally while trying different designs. I don't expect this to be a long lasting patch.

There's some chance trunk will end up using a different allocator to rocm, at least temporarily, in which case this might make @ronlieb's merging slightly easier.

Longer term I'm hopeful that we can drop the heap allocation from the runtime entirely, but we'll still need malloc() for applications so local experimentation would not be wasted.



================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip:55
 
-static void pteam_mem_barrier(uint32_t num_threads, uint32_t * barrier_state)
-{
+static void pteam_mem_barrier(uint32_t num_threads, uint32_t *barrier_state) {
   __atomic_thread_fence(__ATOMIC_ACQUIRE);
----------------
tianshilei1992 wrote:
> unrelated change
git-clang-format appears to ignore *.hip . Really should get around to renaming these


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102499/new/

https://reviews.llvm.org/D102499