[Openmp-commits] [PATCH] D102847: [AMDGPU][Libomptarget] Delete g_atmi_initialized
Jon Chesterfield via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Thu May 20 08:26:01 PDT 2021
JonChesterfield added inline comments.
================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/rt.h:57-62
- // modules
- static atmi_status_t RegisterModuleFromMemory(
- void *, size_t, atmi_place_t,
- atmi_status_t (*on_deserialized_data)(void *data, size_t size,
- void *cb_state),
- void *cb_state, std::vector<hsa_executable_t> &HSAExecutables);
----------------
pdhaliwal wrote:
> This needs to move to D102692.
looks like a separate thing - can we reduce this patch to deleting the variable and the dead branches on it, and shuffle code around + inline things in a separate one?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102847/new/
https://reviews.llvm.org/D102847
More information about the Openmp-commits
mailing list