[Openmp-commits] [PATCH] D86419: fix omp post-generation event statement error on windows

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov requested changes to this revision.
AndreyChurbanov added a comment.
This revision now requires changes to proceed.

In D86419#2768808 <https://reviews.llvm.org/D86419#2768808>, @ahmidou wrote:

> Hi,
> So is the standalone Windows build not failing anymore?

Sorry, I've accepted the patch prematurely I think.
With this patch build is fixed for cmake generators "Visual Studio...", but is broken for e.g. "Unix Makefiles" (I guess this is regardless of whether the build is standalone).
I've accepted the patch when I tried to build clang and standalone libomp using "Visual Studio 16 2019" cmake generator. But "Unix Makefiles" generator still does not work.
Searching for ConfigurationName I found the page https://cmake.org/cmake/help/latest/variable/CMAKE_CFG_INTDIR.html that suggests to use CMAKE_CFG_INTDIR.
And indeed the CMAKE_CFG_INTDIR has the value "$(ConfigurationName)" for "Visual Studio 16 2019" generator and the value "." for "Unix Makefiles" generator, thus the build works for both generators if I replaced $(ConfigurationName) with ${CMAKE_CFG_INTDIR} in your patch.
Could you please check if this replacement works for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86419/new/

https://reviews.llvm.org/D86419