[Openmp-commits] [PATCH] D102692: [AMDGPU][Libomptarget] Move Kernel/Symbol info tables to RTLDeviceInfoTy
Pushpinder Singh via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed May 19 00:56:24 PDT 2021
pdhaliwal added a comment.
> PopulateInfoTablesContext looks like a hazard - it's a struct holding references, which is usually a bad sign for lifetimes. If that's only used to pass data across the void* boundary, let's use a lambda instance instead.
The capturing lambda won't work here so that's why I chose to use a struct of references.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102692/new/
https://reviews.llvm.org/D102692
More information about the Openmp-commits
mailing list