[Openmp-commits] [PATCH] D101977: [OpenMP] Create custom state machines for generic target regions

[Giorgis Georgakoudis via Phabricator via Openmp-commits]

ggeorgakoudis added a comment.

LG, some remarks



================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:507
+
+  /// "Clamp" this state with \p KIS.
+  KernelInfoState operator^=(const KernelInfoState &KIS) {
----------------
Nit, concatenation?


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:610
+    //
+    Function *Kernel = getAssociatedFunction();
+    BasicBlock *InitBB = KernelInitCB->getParent();
----------------
Assertion?


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:684
+
+    // Now that we have most of the CFG skelleton it is time for the if-cascade
+    // that checks the function pointer we got from the runtime against the
----------------
skeleton


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101977/new/

https://reviews.llvm.org/D101977