[Openmp-commits] [PATCH] D102587: [OpenMP] Refine CMake code for libomptarget

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/CMakeLists.txt:47
+  libomptarget_say("Building libomptarget requires LLVM 12.0+ components. Will not build libomptarget.")
+  return()
 endif()
----------------
Could  you unset cached variable OPENMP_ENABLE_LIBOMPTARGET (in a proper place)? Just to keep CMakeCached consistent.

Since OPENMP_ENABLE_LIBOMPTARGET is not in the current CMakeLists.txt, the unset probably needs to be at openmp/CMakeLists.txt
and the current CMakeLists.txt needs to set a return value signalling libomptarget not being built.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102587/new/

https://reviews.llvm.org/D102587