[Openmp-commits] [PATCH] D102587: [OpenMP] Refine CMake code for libomptarget

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

I don't understand the control flow here. It looks like OPENMP_ENABLE_LIBOMPTARGET = ON, as before, but we now check for LLVM=12 on one path and not on another.

I think you sent an email suggesting we should test whether the compiler can actually build the plugin. LLVM==12 probably isn't a sufficiently robust way to do that.

Can cmake handle passing a pre-made c++ file to the compiler to test if it can build? I'm thinking we could craft one that used variant, various intrinsics etc that are representative of the gpu code runtime.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102587/new/

https://reviews.llvm.org/D102587