[Openmp-commits] [PATCH] D101509: An attempt to abandon omptarget out-of-tree builds.

[Wei Wang via Phabricator via Openmp-commits]

weiwang added a comment.

In D101509#2749565 <https://reviews.llvm.org/D101509#2749565>, @vzakhari wrote:

> I have a guess that `clang-resource-headers` are not built at the point, where we invoke `clang`.  Can you please check this workaround in `openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt`?
>
>   add_custom_command(
>     OUTPUT ${bc1_filename}
>     COMMAND ${cu_cmd} ${file} -o ${bc1_filename}
>     DEPENDS ${file} ${h_files} clang-resource-headers)
>
> I added `clang-resource-headers` dependency after `${h_files}`.

Tried the work-around, deviceRTLs is still being built.

Also used `-H` to show the header includes

  #include "..." search starts here:
  #include <...> search starts here:
   /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/amdgcn/src
   /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/include
   /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs
   /home/wangwei/fbsource/fbcode/third-party2/libgcc/9.x/platform009/9202ce7/include/c++/9.x
   /home/wangwei/fbsource/fbcode/third-party2/libgcc/9.x/platform009/9202ce7/include/c++/9.x/x86_64-facebook-linux
   /home/wangwei/fbsource/fbcode/third-party2/libgcc/9.x/platform009/9202ce7/include/c++/9.x/backward
   /home/wangwei/fbsource/fbcode/third-party2/gcc/9.x/centos7-native/3bed279/include
   /home/wangwei/fbsource/fbcode/third-party2/gcc/9.x/centos7-native/3bed279/lib/gcc/x86_64-redhat-linux-gnu/9.x/include
   ... ...
   /usr/local/include
   /data/users/wangwei/tp2/llvm-build/platform009/build_pic/lib/clang/13.0.20190721/include
   /usr/include
  End of search list.
  . /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/omptarget.h
  .. /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/allocator.h
  .. /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/debug.h
  ... /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/device_environment.h
  .... /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
  ..... /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_interface.h
  ...... /home/wangwei/fbsource/fbcode/third-party2/gcc/9.x/centos7-native/3bed279/lib/gcc/x86_64-redhat-linux-gnu/9.x/include/stdint.h
  ....... /home/wangwei/fbsource/fbcode/third-party2/gcc/9.x/centos7-native/3bed279/lib/gcc/x86_64-redhat-linux-gnu/9.x/include/stdint-gcc.h
  ..... /home/wangwei/fbsource/fbcode/third-party2/gcc/9.x/centos7-native/3bed279/lib/gcc/x86_64-redhat-linux-gnu/9.x/include/stddef.h
  ... /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/target_interface.h
  ... /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/support.h
  .... /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/interface.h
  ..... /home/wangwei/fbsource/fbcode/third-party2/gcc/9.x/centos7-native/3bed279/lib/gcc/x86_64-redhat-linux-gnu/9.x/include/stddef.h
  .. /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/state-queue.h
  ... /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/state-queuei.h
  .... /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/state-queue.h
  .. /home/wangwei/local/llvm-project/openmp/libomptarget/deviceRTLs/common/omptargeti.h

`/home/wangwei/fbsource/fbcode/third-party2/gcc/9.x/centos7-native/3bed279/lib/gcc/x86_64-redhat-linux-gnu/9.x/include` comes before `/data/users/wangwei/tp2/llvm-build/platform009/build_pic/lib/clang/13.0.20190721/include`

I wonder if there is a cmake flag to explicitly disable "AMDGCN device RTL" but still build the rest of libomptarget. I think keep disabling deviceRTL is fine since we've never really built it anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101509/new/

https://reviews.llvm.org/D101509