[Openmp-commits] [PATCH] D101030: [OpenMP] Overhaul `declare target` handling

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D101030#2746770 <https://reviews.llvm.org/D101030#2746770>, @gregmiller wrote:

> In D101030#2745513 <https://reviews.llvm.org/D101030#2745513>, @jdoerfert wrote:
>
>> In D101030#2745429 <https://reviews.llvm.org/D101030#2745429>, @gregmiller wrote:
>>
>>> Hello, We are maintaining a downstream version of the monorepo based on the LLVM main branch. We have not transitioned to the new PM yet. In a recent attempt to merge the latest upstream commits into our monorepo we came across the following test failures after your commit.
>>> F16720091: failed_report.txt <https://reviews.llvm.org/F16720091>
>>> For below test cases:
>>>
>>>   remarks_parallel_in_multiple_target_state_machines.c
>>>   remarks_parallel_in_target_state_machine.c
>>>
>>> Thanks
>>> greg
>>
>> Can you add (and if you want upstream) a change that forces the use of the new pass manager for those tests?
>
> Since the old pass manager is still supported upstream, I think it would make more sense for you to update your changes to the failing tests instead.

Sure. I'll do that when I find a minute.
Given that you have a setup with the old PM set as default I figured it might be easier for you to test the minimal change to the run lines but I am happy to do it myself next chance I get to setup everything and such.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101030/new/

https://reviews.llvm.org/D101030