[Openmp-commits] [PATCH] D102000: [libomptarget] Add support for target memory allocators to cuda RTL

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Two nits, otherwise this looks sensible to me.



================
Comment at: openmp/libomptarget/plugins/common/MemoryManager/MemoryManager.h:34
   /// allocation.
-  virtual void *allocate(size_t Size, void *HstPtr) = 0;
+  virtual void *allocate(size_t Size, void *HstPtr, int32_t kind) = 0;
 
----------------
can we have an enum not a int32_t, also variable name `Kind`


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:363
+          return OFFLOAD_FAIL;
+        break;
+      }
----------------
if everything but alloc_host goes to cumemfree, only put alloc_host in the set. If it is not in the set, it's cumemfree teritory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102000/new/

https://reviews.llvm.org/D102000