[Openmp-commits] [PATCH] D101882: [OpenMP] Fix hidden helper + affinity assignment

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

I cannot reproduce the regression with this patch. On 48 core (96 hyperthreads) machine with settings

  GOMP_CPU_AFFINITY=0-95
  OMP_NUM_THREADS=96

I got the following results:

Current library default:
 Success 619.lbm_s base refspeed ratio=67.88, runtime=77.167402
Patch applied:
 Success 619.lbm_s base refspeed ratio=87.54, runtime=59.837863
Helpers=false num_helpers=0:
 Success 619.lbm_s base refspeed ratio=87.28, runtime=60.015925
Helpers=false num_helpers=0 patch applied:
 Success 619.lbm_s base refspeed ratio=87.88, runtime=59.602862

@ronlieb, could you please provide the error output of the library with setting

  KMP_AFFINITY=verbose

for your runs with/without patch applied (slightly improved and slow ones)?

Once the outputs should be big enough, it might be better to attach them to the corresponding bug https://bugs.llvm.org/show_bug.cgi?id=49673 in order to not pollute this review with huge testing logs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101882/new/

https://reviews.llvm.org/D101882