[Openmp-commits] [PATCH] D99656: [AMDGPU][OpenMP] Enable Libomptarget runtime tests

Wed May 5 11:42:42 PDT 2021

JonChesterfield added a comment.

In D99656#2739599 <https://reviews.llvm.org/D99656#2739599>, @protze.joachim wrote:

> In D99656#2739517 <https://reviews.llvm.org/D99656#2739517>, @JonChesterfield wrote:
>
>> Where's the logic to skip running these tests if `./amdgpu-arch` fails?
>
> The tests are included to `check-libomptarget`, if  `llvm-project/openmp/libomptarget/plugins/amdgpu/CMakeLists.txt` reaches the last line, i.e., if the plugin is built.

Ah, that's not ideal. Picked up the same behaviour as nvptx then.

The plugin existing is necessary but not sufficient for running the tests to succeed. One requires the plugin, but also the hardware available locally.

amdgpu-arch returning 0 will correlate strongly with there being a local gpu that tests can run on. Do we have a good place to put a call to that which would control whether to run the amdgpu tests?

We should be able to use a successful call to one of the binaries in the cuda toolkit to do the same test for nvidia, so that people with cuda installed but no nvidia gpu don't run the nvptx tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99656/new/

https://reviews.llvm.org/D99656