[Openmp-commits] [PATCH] D101882: [OpenMP] Fix hidden helper + affinity assignment

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a subscriber: tianshilei1992.
protze.joachim added a comment.

@ronlieb Thanks for testing! When I saw this patch, I thought that broken thread-binding might possibly cause the observed performance issue.

@tianshilei1992 this patch is just another case, confirming my statement in D77609 <https://reviews.llvm.org/D77609>:

> I think, the fundamental issue of this patch is, that it broke the implicit assumption, that entries in __kmp_threads are handed out contiguously.

I wonder, whether it would improve the situation, if we move the hidden helper threads to `__kmp_threads[-8:-1]`, i.e., below the initial thread?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101882/new/

https://reviews.llvm.org/D101882