[Openmp-commits] [PATCH] D101030: [OpenMP] Overhaul `declare target` handling

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

In D101030#2736508 <https://reviews.llvm.org/D101030#2736508>, @jdoerfert wrote:

> I'll wait for @ggeorgakoudis to update the tests with the script, then I'll adjust all clang tests again. FWIW, this also fixes an issue in OpenMC where declare target triggered this:
>
>   llvm-project/clang/lib/CodeGen/CodeGenFunction.cpp:719: void clang::CodeGen::CodeGenFunction::StartFunction(clang::GlobalDecl, clang::QualType, llvm::Function *, const clang::CodeGen::CGFunctionInfo &, const clang::CodeGen::FunctionArgList &, clang::SourceLocation, clang::SourceLocation): Assertion `CurFn->isDeclaration() && "Function already has body?"' failed.

Nice!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101030/new/

https://reviews.llvm.org/D101030