[Openmp-commits] [PATCH] D96893: [OpenMP] libomp minor cleanup

Tue May 4 09:08:27 PDT 2021

AndreyChurbanov added a comment.

In D96893#2736258 <https://reviews.llvm.org/D96893#2736258>, @protze.joachim wrote:

> In D96893#2735978 <https://reviews.llvm.org/D96893#2735978>, @AndreyChurbanov wrote:
>
>> I temporarily disabled assertion until the bug with dependences is fixed.
>
> Did you look at my observations, I documented in https://bugs.llvm.org/show_bug.cgi?id=49723 . I did not completely understand, in which case the behavior could be triggered. If you agree, I'll change to heap allocation of the dep node.

No need to allocate the node on heap because it is not needed after the call to __kmpc_omp_wait_deps. So there should not be any references to the node remained, and it should not be remembered in the dep hash (that is the current problem I think).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96893/new/

https://reviews.llvm.org/D96893