[Openmp-commits] [PATCH] D101509: An attempt to abandon omptarget out-of-tree builds.

[Vyacheslav Zakharin via Phabricator via Openmp-commits]

vzakhari added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:14
+# An installed LLVM package should have been discovered before.
+if (NOT LLVM_DIR)
   libomptarget_say("Not building AMDGCN device RTL: AOMP not found")
----------------
tianshilei1992 wrote:
> This check could be avoided if the include of `libomptarget` is guarded by the check of LLVM. That said, all CMake code in `libomptarget` can assume that LLVM is already there.
There is a check in `openmp/libomptarget/CMakeLists.txt` that will fail, if LLVM is not there:

```
# LLVM source tree is required at build time for libomptarget
if (NOT LIBOMPTARGET_LLVM_INCLUDE_DIRS)
  message(FATAL_ERROR "Missing definition for LIBOMPTARGET_LLVM_INCLUDE_DIRS")
endif()
```

I will remove this check here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101509/new/

https://reviews.llvm.org/D101509