[Openmp-commits] [PATCH] D100181: [OpenMP] [OMPD] [1/6] Implementation of OMPD debugging library - libompd. Code changes in openmp/runtime to support libompd.

[Vignesh Balasubramanian via Phabricator via Openmp-commits]

Vigneshbalu marked 5 inline comments as done.
Vigneshbalu added inline comments.


================
Comment at: openmp/runtime/src/ompd-specific.cpp:40
+
+int ompd_rtl_version = 7;
+
----------------
hbae wrote:
> Can you add some comments why it is 7.
Thanks Hansang. it is unwanted variable and removed it


================
Comment at: openmp/runtime/src/ompd-specific.h:126-127
+
+// TODO: (mr) this is a hack to cast cuda contexts to 64 bit values
+typedef uint64_t ompd_cuda_context_ptr_t;
+
----------------
protze.joachim wrote:
> Please drop these lines. The current patches don't include any cuda stuff.
Done


================
Comment at: openmp/runtime/src/ompd-specific.h:156
+  OMPD_SIZEOF(__kmp_nth)                                                       \
+  OMPD_SIZEOF(ompd_cuda_context_ptr_t)
+
----------------
protze.joachim wrote:
> same here, drop the cuda symbol
Thanks for the catch joachim


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100181/new/

https://reviews.llvm.org/D100181