[Openmp-commits] [PATCH] D94565: [libomptarget][nvptx] Include omp_data.cu in bitcode deviceRTL

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Bug https://bugs.llvm.org/show_bug.cgi?id=49764 points at this change as increasing device memory use. Previously the bitcode and the archive were both linked, where this file was always in the archive. After this commit, no files will have been extracted from the archive (and shortly afterwards the archive was dropped entirely).

If no symbols from omp_data.cu were used in some test case, and the bitcode version is not being deadstripped, then data use would increase. Both of those requirements seem unlikely.

It would be good to check that the devicertl symbols are being internalized for nvptx, as otherwise unused variables with global visibility will tend to remain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94565/new/

https://reviews.llvm.org/D94565