[Openmp-commits] [PATCH] D96444: [OpenMP][NFC] Use `AsyncInfo` as the variable name for a `__tgt_async_info`

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a subscriber: atmnpatel.
jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins/remote/server/Server.cpp:167
     Reply->set_number(PM->Devices[Info->device_id()].synchronize(
-        (__tgt_async_info *)AsyncInfoPtr));
+        (__tgt_async_info *)AsyncInfo));
 
----------------
rogfer01 wrote:
> I don't think this is caused by this patch, but I'm unable to build this using clang trunk (I'm building openmp as a `runtime`).
> 
> ```
> /work/llvm-src/openmp/libomptarget/plugins/remote/server/Server.cpp:169:9: error: non-const lvalue reference to type 'AsyncInfoTy' cannot bind to a temporary of type '__tgt_async_info *'
>         (__tgt_async_info *)AsyncInfo));
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /work/llvm-src/openmp/libomptarget/src/device.h:223:36: note: passing argument to parameter 'AsyncInfo' here
>   int32_t synchronize(AsyncInfoTy &AsyncInfo);
>                                    ^
> ```
> 
> Has anyone else run into this? What version of clang (or gcc?) do you commonly use to build this code? Thanks!
@atmnpatel was looking into this. I forgot to rename that part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96444/new/

https://reviews.llvm.org/D96444