[Openmp-commits] [PATCH] D98838: [OpenMP] Fixed a crash in hidden helper thread

Thu Mar 18 16:30:31 PDT 2021

jdoerfert added a comment.

In D98838#2635728 <https://reviews.llvm.org/D98838#2635728>, @JonChesterfield wrote:

> In D98838#2635384 <https://reviews.llvm.org/D98838#2635384>, @jdoerfert wrote:
>
>> 
>
> In the spirit of direct, I didn't care about this change until it landed and broke stuff.

As far as I can tell, we merged Jan 25, Ron reported an issue March 15. In addition to the
review time, it was upstream for 8 weeks before you reported it broke stuff. Given that delay
I would not throw rocks at people claiming they did not do any testing. It's not like we don't
try to setup LLVM/OpenMP CI and such.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98838/new/

https://reviews.llvm.org/D98838