[Openmp-commits] [PATCH] D98838: [OpenMP] Fixed a crash in hidden helper thread

[Narayanaswamy, Ravi via Openmp-commits]

Shilei,
   How much time do  you think you  need to resolve or conclude to revert or disable with macros in 12.0
Some would like to stabilize their performance numbers and would  like to do it as early as possible.
Thanks
Ravi

-----Original Message-----
From: Shilei Tian via Phabricator <reviews at reviews.llvm.org> 
Sent: Thursday, March 18, 2021 9:59 AM
To: tianshilei1992 at gmail.com; ron.lieberman at amd.com; protze.joachim at gmail.com; lebedev.ri at gmail.com; jonathanchesterfield at gmail.com; jdoerfert at anl.gov
Cc: xw111luoye at gmail.com; sourabhsingh.tomar at amd.com; simon.moll at emea.nec.com; sara.royuela at bsc.es; Saiyedul.Islam at amd.com; Narayanaswamy, Ravi <ravi.narayanaswamy at intel.com>; lin32 at llnl.gov; liao6 at llnl.gov; jatin.bhateja at gmail.com; greg63706 at gmail.com; fghanim84 at gmail.com; deepak.eachempati at hpe.com; david.green at arm.com; bhuvanendra.kumarn at amd.com; a.bataev at hotmail.com; yaxun.liu at amd.com; stefomeister at gmail.com; zhang.guansong at gmail.com; openmp-commits at lists.llvm.org; pdhaliwal at amd.com
Subject: [PATCH] D98838: [OpenMP] Fixed a crash in hidden helper thread

tianshilei1992 marked 5 inline comments as done.
tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:4323
          ++new_gtid) {
       KMP_DEBUG_ASSERT(new_gtid < __kmp_threads_capacity);
     }
----------------
protze.joachim wrote:
> This assertion triggers for your test application, when the runtime is built in debug mode. 
> 
> 
Can you try again?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98838/new/

https://reviews.llvm.org/D98838