[Openmp-commits] [PATCH] D98677: [OpenMP][FIX] Repair accidental replacement of _shfl_sync with _shfl

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Mar 15 19:53:43 PDT 2021

jdoerfert created this revision.
jdoerfert added reviewers: JonChesterfield, tianshilei1992.
Herald added subscribers: guansong, yaxunl.
Herald added a reviewer: bollu.
jdoerfert requested review of this revision.
Herald added a subscriber: sstefan1.
Herald added a project: OpenMP.

This was broken accidentally in D95752 <https://reviews.llvm.org/D95752>.

  rG LLVM Github Monorepo



Index: openmp/libomptarget/deviceRTLs/common/include/target/shuffle.h
--- openmp/libomptarget/deviceRTLs/common/include/target/shuffle.h
+++ openmp/libomptarget/deviceRTLs/common/include/target/shuffle.h
@@ -90,13 +90,13 @@
 inline int32_t __kmpc_impl_shfl_sync(uint64_t Mask, int32_t Var,
                                      int32_t SrcLane) {
-  return __nvvm_shfl_idx_i32(Var, SrcLane, 0x1f);
+  return __nvvm_shfl_sync_idx_i32(Mask, Var, SrcLane, 0x1f);
 inline int32_t __kmpc_impl_shfl_down_sync(uint64_t Mask, int32_t Var,
                                           uint32_t Delta, int32_t Width) {
   int32_t T = ((GetWarpSize() - Width) << 8) | 0x1f;
-  return __nvvm_shfl_down_i32(Var, Delta, T);
+  return __nvvm_shfl_sync_down_i32(Mask, Var, Delta, T);
 #pragma omp end declare variant

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98677.330867.patch
Type: text/x-patch
Size: 879 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210316/26c12848/attachment.bin>

More information about the Openmp-commits mailing list