[Openmp-commits] [PATCH] D97883: [libomptarget] Add allocator support for target memory

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Apologies for missing this. Looks reasonable to me. I'll wire up the amdgcn plugin when I find some time.



================
Comment at: openmp/libomptarget/include/omptarget.h:203
+void *llvm_omp_target_alloc_device(size_t size, int device_num);
+void *llvm_omp_target_alloc_host(size_t size, int device_num);
+void *llvm_omp_target_alloc_shared(size_t size, int device_num);
----------------
Is alloc_host expected to ignore the device_num argument?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97883/new/

https://reviews.llvm.org/D97883