[Openmp-commits] [PATCH] D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Do we want to add a test for this?



================
Comment at: openmp/runtime/src/i18n/en_US.txt:459
+UserDirectedError            "Encountered user-directed error: %1$s at %2$s."
+UserDirectedWarning          "Encountered user-directed warning: %1$s at %2$s."
 FailedToCreateTeam           "Failed to create teams between lower bound (%1$d) and upper bound (%2$d)."
----------------
I would go with:
`"%2%s: Encountered user-directed error: %1$s"`
as we do it above like this as well.


================
Comment at: openmp/runtime/src/kmp_csupport.cpp:4380
+    KMP_FATAL(UserDirectedError, message, psource);
+}
----------------
Don't we have a method to "pretty print" the psource such that it reads: "file:line:column"
For unknown, maybe just "unknown".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98448/new/

https://reviews.llvm.org/D98448