[Openmp-commits] [PATCH] D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D98448#2626224 <https://reviews.llvm.org/D98448#2626224>, @hbae wrote:

> It is unclear what we should do with ident_t at the moment.
> Is it going to be useful if we include the location info in the warning/error message?

I would argue immensely, it would also match our compile time error reporting which has locations.
There seems to be little cost in accepting an ident_t anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98448/new/

https://reviews.llvm.org/D98448