[Openmp-commits] [PATCH] D98565: [libomptarget][amdgcn] Drop use of inttypes.h, moving closer to freestanding

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h:24
 
+// subset of inttypes.h
+#define PRId64 "ld"
----------------
Could equally remove the handful of uses of these macros, but this seems fine. The target_impl header is internal to the library.


================
Comment at: openmp/libomptarget/deviceRTLs/common/include/target/shuffle.h:19
 #include <assert.h>
-#include <inttypes.h>
+#include <stdint.h>
 
----------------
This didn't use stuff from inttypes specifically, stdint suffices


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98565/new/

https://reviews.llvm.org/D98565