[Openmp-commits] [PATCH] D97883: [libomptarget] Add allocator support for target memory

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/plugins/generic-elf-64bit/src/rtl.cpp:260
+// are equivalent to each other.
+void *__tgt_rtl_data_alloc_explicit(int32_t device_id, int64_t size,
+                                    int32_t kind) {
----------------
I think we can extend `__tgt_rtl_data_alloc` here by adding a default argument `kind` such that it has the same semantic as `__tgt_rtl_data_alloc`. `__tgt_rtl_data_alloc_explicit` sounds weird...After all, it is internal interface so it will not break anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97883/new/

https://reviews.llvm.org/D97883