[Openmp-commits] [PATCH] D105121: [OpenMP] Avoid checking parent reference count in targetDataBegin

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny added a comment.

In D105121#2847359 <https://reviews.llvm.org/D105121#2847359>, @jhuber6 wrote:

> In D105121#2847309 <https://reviews.llvm.org/D105121#2847309>, @jdenny wrote:
>
>> In D105121#2847256 <https://reviews.llvm.org/D105121#2847256>, @jdoerfert wrote:
>>
>>> We should also run it through all the offload apps we have in FAROS.
>>
>> I've not tried FAROS before.  If you're requesting that I do this, please give me a pointer, and I'll be glad to investigate.
>
> You can also build the tests manually if you find that easier. Right now FAROS only tests XSBench, RSBench, miniFE, and miniQMC for its offloading checks.

I ran all four of those using FAROS, and I ran make test within miniQMC.  I saw no failures, either before or after applying this patch plus D104924 <https://reviews.llvm.org/D104924>.

However, only XSBench and RSBench report on result verification, as far as I can tell.  If there's a simple way to verify miniFE and miniQMC results (other than miniQMC's make test), let me know.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105121/new/

https://reviews.llvm.org/D105121