[Openmp-commits] [PATCH] D105211: [OpenMP][Offloading] Replace all calls to `isSPMDMode` with `__kmpc_is_spmd_exec_mode`

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/common/src/omptarget.cu:165
 EXTERN int8_t __kmpc_is_spmd_exec_mode() {
   PRINT0(LD_IO | LD_PAR, "call to __kmpc_is_spmd_exec_mode\n");
+  return (execution_param & ModeMask) == Spmd;
----------------
Ah, bad. This change introduces PRINT0 calls absolutely everywhere. That will make a mess.

My preference would be to delete this PRINT0 call.

If we can't do that, I guess we could still with one function called internally that doesn't print and one function called externally that does, but 'external' in this context is clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105211/new/

https://reviews.llvm.org/D105211