[Openmp-commits] [PATCH] D105073: [libomptarget] [amdgpu] Fix default setting of max flat workgroup size

[Dhruva Chakrabarti via Phabricator via Openmp-commits]

dhruvachak added a comment.

> I guess this avoids a case where threadsPerGroup is set to zero by a zero ConstWGSize.

The scenario I am fixing is what happens in the default case today. No flat max-work-group size is intended, so it starts off as 0 but then we set ConstWGSize to 256 if the former is 0 (line 1710 above). So getLaunchVals limits threadsPerGroup to 256 because ConstWGSize is 256. My fix allows setting threadsPerGroup beyond 256 but limited to 1024.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105073/new/

https://reviews.llvm.org/D105073