[Openmp-commits] [PATCH] D104788: [OpenMP] Fix builds for non-x86 after distributed barrier patch

[Giorgis Georgakoudis via Phabricator via Openmp-commits]

ggeorgakoudis added a comment.

I had the same compilation errors mentioned in D103121 <https://reviews.llvm.org/D103121> on an IBM machine. I can confirm that errors go away and compilation finishes. However, there are several warnings on overriden functions and virtual destructors, for example:

  .../llvm-project/openmp/runtime/src/kmp_wait_release.h:958:8: warning: 'notdone_check' overrides a member
   function but is not marked 'override' [-Wsuggest-override]                                                                               
    bool notdone_check() {                                                                                                                  
         ^                                                                                                                                  
  .../llvm-project/openmp/runtime/src/kmp_wait_release.h:178:16: note: overridden virtual function is here 
    virtual bool notdone_check() {  

and

  .../llvm-project/openmp/runtime/src/kmp.h:266:48: warning: 'kmp_flag_64<false, true>' has virtual functio
  ns but non-virtual destructor [-Wnon-virtual-dtor]                                                                                        
  template <bool C = false, bool S = true> class kmp_flag_64;                                                                               
                                                 ^            

which should be reasonable to fix too. Happy to provide a more detailed log if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104788/new/

https://reviews.llvm.org/D104788