[Openmp-commits] [PATCH] D104923: [libomptarget][amdgpu][nfc] Fix build warnings, drop some headers

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/internal.h:208
 const char *get_error_string(hsa_status_t err);
-const char *get_atmi_error_string(hsa_status_t err);
 
----------------
atmi_error_string was a subset of get_error_string


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:13
 #include <set>
+#include <sstream>
 #include <string>
----------------
stringstream is currently used for some formatting, don't need to include iostream to get that


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/utils.cpp:15
+  hsa_status_t rc = hsa_status_string(err, &res);
+  return (rc == HSA_STATUS_SUCCESS) ? res : "HSA_STATUS UNKNOWN.";
 }
----------------
hsa includes essentially the same switch as here, but provides some more context on the error meaning, and avoids warnings about missing cases in the switch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104923/new/

https://reviews.llvm.org/D104923