[Openmp-commits] [PATCH] D103648: [OpenMP] libomp: fix dynamic loop dispatcher

[Hongtao Yu via Phabricator via Openmp-commits]

hoy added a comment.

In D103648#2839789 <https://reviews.llvm.org/D103648#2839789>, @AndreyChurbanov wrote:

> In D103648#2839482 <https://reviews.llvm.org/D103648#2839482>, @hoy wrote:
>
>> Hello, I was seeing an assert firing in kmp_dispatch.cpp when running the omp_parallel_reduction.c test with a -DLLVM_ENABLE_ASSERTIONS enabled toolset. Would you mind taking a look? Thanks.
>>
>> - TEST 'libomp :: parallel/omp_parallel_reduction.c' FAILED ********************
>>
>> Script:
>> ... omitted
>>
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>> OMP: Error #13: Assertion failure at kmp_dispatch.cpp(1453).
>> OMP: Hint Please submit a bug report with this message, compile and run commands used, and machine configuration info including native compiler and operating system versions. Faster response will be obtained by including all program sources. For information on submitting this issue, please see https://bugs.llvm.org/.
>> Assertion failure at kmp_dispatch.cpp(1453): (vnew.p.ub - 1) * (UT)chunk <= trip.
>>
>>   
>
> Thanks for reporting.
> Actually the wrong assertion existed before this patch, which apparently increased the probability of its triggering.
> I've fixed the assertion in https://reviews.llvm.org/D104880.

Thanks for the fast turnaround!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103648/new/

https://reviews.llvm.org/D103648