[Openmp-commits] [PATCH] D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:192-195
                            map_var_info_t HstPtrName, bool MoveData,
                            bool IsImplicit, bool UpdateRefCount,
                            bool HasCloseModifier, bool HasPresentModifier,
                            AsyncInfoTy &AsyncInfo) {
----------------
Which patch removes the `bool &IsHostPtr,` argument?
I cannot see this change in any of the patches in the stack or on main.

This patch fails to apply after applying the other two patches in the stack.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:501-509
-<<<<<<< HEAD
-      DP("There are %zu bytes allocated at target address " DPxMOD "\n",
-         sizeof(void *), DPxPTR(PointerTgtPtrBegin));
-=======
       DP("There are %zu bytes allocated at target address " DPxMOD " - is%s new"
          "\n",
          sizeof(void *), DPxPTR(PointerTgtPtrBegin),
----------------
This probably shouldn't be here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104418/new/

https://reviews.llvm.org/D104418